sijie commented on a change in pull request #6052: [PIP-54] Acknowledgement for
batch message local index
URL: https://github.com/apache/pulsar/pull/6052#discussion_r367980477
##########
File path: pulsar-common/src/main/proto/PulsarApi.proto
##########
@@ -477,6 +484,8 @@ message CommandAck {
optional uint64 txnid_least_bits = 6 [default = 0];
optional uint64 txnid_most_bits = 7 [default = 0];
+
+ repeated BatchMessageIndexesAckData batch_message_ack_indexes = 8;
Review comment:
If we added an `ackSet` bitset to MessageIdData, we don't need to introduce
additional structure, no?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
