sijie commented on a change in pull request #5985: [Issue 5935] Support multi
pulsar clusters to use the same bk cluster
URL: https://github.com/apache/pulsar/pull/5985#discussion_r368249653
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/PulsarClusterMetadataSetup.java
##########
@@ -170,16 +170,11 @@ public static void main(String[] args) throws Exception {
ZooKeeper localZk = initZk(arguments.zookeeper,
arguments.zkSessionTimeoutMillis);
ZooKeeper configStoreZk = initZk(arguments.configurationStore,
arguments.zkSessionTimeoutMillis);
- // Format BookKeeper ledger storage metadata
+ // Format BookKeeper stream storage metadata
ServerConfiguration bkConf = new ServerConfiguration();
bkConf.setZkServers(arguments.zookeeper);
bkConf.setZkTimeout(arguments.zkSessionTimeoutMillis);
- if (localZk.exists("/ledgers", false) == null // only format if
/ledgers doesn't exist
Review comment:
why do we remove this logic?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
