sijie commented on a change in pull request #5985: [Issue 5935] Support multi
pulsar clusters to use the same bk cluster
URL: https://github.com/apache/pulsar/pull/5985#discussion_r368249756
##########
File path:
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
##########
@@ -743,6 +743,18 @@
private String kinitCommand = "/usr/bin/kinit";
/**** --- BookKeeper Client --- ****/
+ @FieldContext(
+ category = CATEGORY_STORAGE_BK,
+ doc = "BookKeeper ledgers storage connection string when using a
separated BookKeeper cluster."
+ + " If not set it will use local zookeeper quorum of Pulsar
cluster"
+ )
+ private String bookkeeperLedgersStore;
Review comment:
in bookkeeper we deprecated using two separate settings. we are encouraging
people to use metadata service uri to connect to a zookeeper cluster. we should
try to adopt it in Pulsar. Thus if we are adding the support for a separate
bookkeeper cluster, let's try to use metadata service uri.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
