ivankelly commented on a change in pull request #6129: [CPP] Compile fixes for
ARM cpus
URL: https://github.com/apache/pulsar/pull/6129#discussion_r370039847
##########
File path: pulsar-client-cpp/lib/checksum/crc32c_sse42.cc
##########
@@ -228,3 +239,12 @@ uint32_t crc32c(uint32_t init, const void *buf, size_t
len, const chunk_config *
DEBUG_PRINTF1("crc = 0x%08x\n", crc);
return crc;
}
+
+#else // ! BOOST_ARCH_X86_64
Review comment:
Does this mean that arm clients can't use crc32c at all?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
