merlimat commented on a change in pull request #6129: [CPP] Compile fixes for 
ARM cpus
URL: https://github.com/apache/pulsar/pull/6129#discussion_r370234857
 
 

 ##########
 File path: pulsar-client-cpp/perf/RateLimiter.h
 ##########
 @@ -50,7 +50,7 @@ RateLimiter::RateLimiter(double rate)
         : interval_(std::chrono::microseconds((long)(1e6 / rate))),
           storedPermits_(0.0),
           maxPermits_(rate),
-          nextFree_() {
 
 Review comment:
   These are to correct some initialization differences with the compiler/arch 
combinations. Without these, the simple perf producer was not working on arm 
with GCC 6.3.
   
   It's mentioned (although briefly) in the description: 
   
   > Fixed some variables initialization
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to