EugenDueck commented on issue #6209: [broker] add feature BrokerDeduplicationAcrossProducers URL: https://github.com/apache/pulsar/pull/6209#issuecomment-583324367 I've just committed a change that adds a _producer group mode_. I would like to know if that's along the lines of what @sijie and @merlimat where suggesting. If it is, I intend to 1) add more extensive unit tests 2) add documentation. I have not implemented the _failover mode_, but it is taken into account by means of the `GroupMode` enum, which currently has the values `Exclusive` and `Parallel` only, but which I created so it can be extended by a `FailOver` value in the future. Btw I'm not totally happy by the use of the `IdentityHashSet`, but I haven't found any good discriminator so far that I can use in order to put multiple producers, which are currently considered identical (producerName + topic), into the same `Set`. I considered `cnx.clientAddress()`, but this does not work with tests at least - where the `clientAddress` would be the same for multiple producers - will look into that again. If you guys have any idea in the meantime, do let me know
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
