codelipenghui commented on issue #6209: [broker] add feature BrokerDeduplicationAcrossProducers URL: https://github.com/apache/pulsar/pull/6209#issuecomment-583677125 @EugenDueck I have understood the current implementation, just some minor suggestions. If we introduce a producer group, I think it needs a clear definition. If only use group type to indicate a producer group, it seems that a topic can only have a few groups at most(Equal to the number of types of producer group). This is why I recommend adding producer group name here. I also think this is better understood by users. If agree with the suggestion above, a topic may have multiple producer groups with different group types. So use a flag to indicate the duplication is based on producer name or producer group name is more flexible and understandable. Just some small suggestions, please point out any misunderstandings. If these are currently not necessary, we can ignore it first.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
