sijie commented on issue #6209: [broker] add feature BrokerDeduplicationAcrossProducers URL: https://github.com/apache/pulsar/pull/6209#issuecomment-584005489 @EugenDueck @codelipenghui I think you are on the same page. the only question here is - are we using "producer name" for identifying the group of producers (what I originally suggested and what @EugenDueck implemented) or introducing a new field "producer group name" in both producer builder and as well as in the wire protocol for identifying the group of producers (what @codelipenghui suggested). I don't have any strong preferences about either approach. just from an operation perspective, if we re-use "producer name" for identifying the group, does it affect stats returned by `topic stats` (question to @codelipenghui). If it is affecting stats, we might just consider adding another field "producer group name" for identifying the group. for @EugenDueck, I don't think you need to re-do your current work if we need to add another field for identifying producer group.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
