sijie commented on a change in pull request #6178: Introduce
maxMessagePublishBufferSizeInMB configuration to avoid broker OOM
URL: https://github.com/apache/pulsar/pull/6178#discussion_r379170140
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
##########
@@ -216,8 +218,17 @@
private Channel listenChannel;
private Channel listenChannelTls;
+ private final long maxMessagePublishBufferSize;
+ private final long resumeProducerReadMessagePublishBufferSize;
+ private volatile long currentMessagePublishBufferSize;
Review comment:
```suggestion
private volatile long currentMessagePublishBufferBytes;
```
I prefer using `bytes` rather than `size` to make the unit more explicit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
