sijie commented on a change in pull request #6178: Introduce
maxMessagePublishBufferSizeInMB configuration to avoid broker OOM
URL: https://github.com/apache/pulsar/pull/6178#discussion_r379168356
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
##########
@@ -257,6 +268,8 @@ public BrokerService(PulsarService pulsar) throws
Exception {
.newSingleThreadScheduledExecutor(new
DefaultThreadFactory("pulsar-msg-expiry-monitor"));
this.compactionMonitor =
Executors.newSingleThreadScheduledExecutor(new
DefaultThreadFactory("pulsar-compaction-monitor"));
+ this.messagePublishBufferMonitor =
Review comment:
We should create this executor only when the feature is enabled.
Also I see we are creating more and more schedulers. Can we consider reusing
some of the executors?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
