codelipenghui commented on a change in pull request #6052: [PIP-54] Support
acknowledgment at batch index level
URL: https://github.com/apache/pulsar/pull/6052#discussion_r380620179
##########
File path:
pulsar-common/src/main/java/org/apache/pulsar/common/api/proto/PulsarApi.java
##########
@@ -1209,11 +1214,26 @@ public int getBatchIndex() {
return batchIndex_;
}
+ // repeated int64 ackSet = 5;
+ public static final int ACKSET_FIELD_NUMBER = 5;
+ private java.util.List<java.lang.Long> ackSet_;
+ public java.util.List<java.lang.Long>
+ getAckSetList() {
+ return ackSet_;
+ }
+ public int getAckSetCount() {
+ return ackSet_.size();
+ }
+ public long getAckSet(int index) {
+ return ackSet_.get(index);
+ }
+
private void initFields() {
ledgerId_ = 0L;
entryId_ = 0L;
partition_ = -1;
batchIndex_ = -1;
+ ackSet_ = java.util.Collections.emptyList();;
Review comment:
The PulsarApi.java is generated by a proto tool. So I won’t do it manually
here, it's better to improve the generation tool.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
