codelipenghui commented on a change in pull request #6052: [PIP-54] Support
acknowledgment at batch index level
URL: https://github.com/apache/pulsar/pull/6052#discussion_r380627511
##########
File path:
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
##########
@@ -171,6 +171,9 @@
+ " affecting the accuracy of the delivery time compared to the
scheduled time. Default is 1 second.")
private long delayedDeliveryTickTimeMillis = 1000;
+ @FieldContext(category = CATEGORY_SERVER, doc = "Whether to enable the
acknowledge of batch local index")
+ private boolean batchIndexAcknowledgeEnable = true;
Review comment:
Should we consider adding a flag to enable or disable at consumer side? I
think this feature does not introduce too much overhead on the consumer side.
For troubleshooting, users just to ensure that their brokers are enabled
this feature and the client version is 2.6.0
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
