cckellogg commented on a change in pull request #198: Fix pprof typo
URL: https://github.com/apache/pulsar-client-go/pull/198#discussion_r394778518
##########
File path: perf/pulsar-perf-go.go
##########
@@ -69,6 +70,15 @@ func main() {
Use: "pulsar-perf-go",
}
+ go func() {
Review comment:
I'm not against the feature i just think it should be hidden behind a cli
flag and not started by default. There is already a FlagProfile and a profiling
server is started when that is enabled. Can this profiling be added to that
server? I'm confused on why two servers need to be started.
If you start `pulsar-perf produce` and `pulsar-perf consume` on your laptop
won't the server try to bind to same port and one of them not start?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
