cckellogg commented on a change in pull request #198: Fix pprof typo
URL: https://github.com/apache/pulsar-client-go/pull/198#discussion_r395201667
##########
File path: perf/pulsar-perf-go.go
##########
@@ -98,12 +99,33 @@ func stopCh() <-chan struct{} {
func RunProfiling(stop <-chan struct{}) {
go func() {
- if err := serveProfiling("0.0.0.0:6060", stop); err != nil &&
err != http.ErrServerClosed {
+ addr := getIntranetIP()
+ if err := serveProfiling(addr, stop); err != nil && err !=
http.ErrServerClosed {
log.WithError(err).Error("Unable to start debug
profiling server")
}
}()
}
+func getIntranetIP() string {
Review comment:
Why is this needed? We would still run into a port binding issues when
running a producer and consumer right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
