jeffgrunewald opened a new pull request #6680: [Issue 5979][pulsar-websocket] Add cumulative acknowledgement to websocket consumer URL: https://github.com/apache/pulsar/pull/6680 Fixes #5979 ### Motivation To make consuming off a websocket more efficient, enabling cumulative acknowledgement will enable consumers to acknowledge chunks of messages and require fewer total responses than a per-message acknowledgement. Per my suggestion in issue #5979 I wanted to submit a proposed implementation for feedback and see if this would be an acceptable solution to the problem. ### Modifications *Describe the modifications you've done.* ### Verifying this change This change is a trivial rework / code cleanup without any test coverage ### Does this pull request potentially affect one of the following parts: - The public API: With this change, websocket clients can now acknowledge by passing ack messages to the consumer like `{"messageId":"CAoQKA=="}` as before, or pass `{"messageId":"CAoQKA==","ackType":"cumulative"}` to acknowledge all unacked message up to and including the one identified by the message ID returned in the ack message. - The schema: The schema of the ConsumerCommand class now includes a new field. ### Documentation I'm unsure where to document the feature but would be happy to do so.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
