massakam commented on a change in pull request #6680: [Issue
5979][pulsar-websocket] Add cumulative acknowledgement to websocket consumer
URL: https://github.com/apache/pulsar/pull/6680#discussion_r407318527
##########
File path:
pulsar-websocket/src/main/java/org/apache/pulsar/websocket/ConsumerHandler.java
##########
@@ -240,12 +242,27 @@ public void onWebSocketText(String message) {
// We should have received an ack
MessageId msgId =
MessageId.fromByteArrayWithTopic(Base64.getDecoder().decode(command.messageId),
topic.toString());
- consumer.acknowledgeAsync(msgId).thenAccept(consumer ->
numMsgsAcked.increment());
- if (!this.pullMode) {
- int pending = pendingMessages.getAndDecrement();
- if (pending >= maxPendingMessages) {
- // Resume delivery
- receiveMessage();
+ if ("cumulative".equals(command.ackType)) {
+ ConsumerStats cStats = consumer.getStats();
+ long ackDiff = cStats.getTotalMsgsReceived() -
cStats.getTotalAcksSent();
Review comment:
Umm... I don't think there is such an interface.
We can find the number of messages between the two message IDs on the broker
side, but it is difficult on the websocket proxy side.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
