murong00 commented on a change in pull request #6637: [pulsar-broker] Implement
AutoSubscriptionCreation by namespace override
URL: https://github.com/apache/pulsar/pull/6637#discussion_r404510526
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java
##########
@@ -653,6 +654,101 @@ protected void
internalRemoveAutoTopicCreation(AsyncResponse asyncResponse) {
});
}
+ protected void internalSetAutoSubscriptionCreation(AsyncResponse
asyncResponse, AutoSubscriptionCreationOverride
autoSubscriptionCreationOverride) {
+ validateAdminAccessForTenant(namespaceName.getTenant());
+ validatePoliciesReadOnlyAccess();
+
+ // Force to read the data s.t. the watch to the cache content is setup.
+ policiesCache().getWithStatAsync(path(POLICIES,
namespaceName.toString())).thenApply(
+ policies -> {
+ if (policies.isPresent()) {
+ Entry<Policies, Stat> policiesNode = policies.get();
+ policiesNode.getKey().autoSubscriptionCreationOverride
= autoSubscriptionCreationOverride;
+ try {
+ // Write back the new policies into zookeeper
+ globalZk().setData(path(POLICIES,
namespaceName.toString()),
+
jsonMapper().writeValueAsBytes(policiesNode.getKey()),
policiesNode.getValue().getVersion());
+ policiesCache().invalidate(path(POLICIES,
namespaceName.toString()));
+ asyncResponse.resume(Response.noContent().build());
+ String autoOverride =
autoSubscriptionCreationOverride.allowAutoSubscriptionCreation ? "enabled" :
"disabled";
+ log.info("[{}] Successfully {}
autoSubscriptionCreation on namespace {}", clientAppId(), autoOverride,
namespaceName);
+ return null;
+ } catch (KeeperException.NoNodeException e) {
+ log.error("[{}] Failed to modify
autoSubscriptionCreation status for namespace {}: does not exist",
clientAppId(),
+ namespaceName);
+ asyncResponse.resume(new
RestException(Status.NOT_FOUND, "Namespace does not exist"));
+ return null;
+ } catch (KeeperException.BadVersionException e) {
+ log.error(
+ "[{}] Failed to modify
autoSubscriptionCreation status on namespace {} expected policy node version={}
: concurrent modification",
+ clientAppId(), namespaceName,
policiesNode.getValue().getVersion());
+
+ asyncResponse.resume(new
RestException(Status.CONFLICT, "Concurrent modification"));
+ return null;
+ } catch (Exception e) {
+ log.error("[{}] Failed to modify
autoSubscriptionCreation status on namespace {}", clientAppId(), namespaceName,
e);
+ asyncResponse.resume(new RestException(e));
+ return null;
+ }
+ } else {
+ asyncResponse.resume(new
RestException(Status.NOT_FOUND, "Namespace " + namespaceName + " does not
exist"));
+ return null;
+ }
+ }
+ ).exceptionally(e -> {
+ log.error("[{}] Failed to modify autoSubscriptionCreation status
on namespace {}", clientAppId(), namespaceName, e);
+ asyncResponse.resume(new RestException(e));
+ return null;
+ });
+ }
+
+ protected void internalRemoveAutoSubscriptionCreation(AsyncResponse
asyncResponse) {
+ validateAdminAccessForTenant(namespaceName.getTenant());
+ validatePoliciesReadOnlyAccess();
+
+ // Force to read the data s.t. the watch to the cache content is setup.
+ policiesCache().getWithStatAsync(path(POLICIES,
namespaceName.toString())).thenApply(
+ policies -> {
+ if (policies.isPresent()) {
+ Entry<Policies, Stat> policiesNode = policies.get();
+ policiesNode.getKey().autoSubscriptionCreationOverride
= null;
+ try {
+ // Write back the new policies into zookeeper
+ globalZk().setData(path(POLICIES,
namespaceName.toString()),
+
jsonMapper().writeValueAsBytes(policiesNode.getKey()),
policiesNode.getValue().getVersion());
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
