codelipenghui commented on a change in pull request #6637: [pulsar-broker]
Implement AutoSubscriptionCreation by namespace override
URL: https://github.com/apache/pulsar/pull/6637#discussion_r405436687
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java
##########
@@ -615,29 +673,87 @@ protected void
internalRemoveAutoTopicCreation(AsyncResponse asyncResponse) {
policies -> {
if (policies.isPresent()) {
Entry<Policies, Stat> policiesNode = policies.get();
- policiesNode.getKey().autoTopicCreationOverride = null;
+ policiesNode.getKey().autoSubscriptionCreationOverride
= autoSubscriptionCreationOverride;
try {
// Write back the new policies into zookeeper
globalZk().setData(path(POLICIES,
namespaceName.toString()),
-
jsonMapper().writeValueAsBytes(policiesNode.getKey()),
policiesNode.getValue().getVersion());
- policiesCache().invalidate(path(POLICIES,
namespaceName.toString()));
+
jsonMapper().writeValueAsBytes(policiesNode.getKey()),
policiesNode.getValue().getVersion(),
+ (rc, path1, ctx, stat) -> {
+ if (rc ==
KeeperException.Code.OK.intValue()) {
+
policiesCache().invalidate(path(POLICIES, namespaceName.toString()));
+ } else {
+ String errorMsg = String.format(
+ "[%s] Failed to modify
autoSubscriptionCreation status for namespace %s",
+ clientAppId(),
namespaceName);
+ if (rc ==
KeeperException.Code.NONODE.intValue()) {
+ log.warn("{} : does not
exist", errorMsg);
+ asyncResponse.resume(new
RestException(Status.NOT_FOUND, "Namespace does not exist"));
+ } else if (rc ==
KeeperException.Code.BADVERSION.intValue()) {
+ log.warn("{} : concurrent
modification", errorMsg);
+ asyncResponse.resume(new
RestException(Status.CONFLICT, "Concurrent modification"));
+ } else {
+
asyncResponse.resume(KeeperException.create(KeeperException.Code.get(rc),
errorMsg));
+ }
+ }
+ }, null);
+ String autoOverride =
autoSubscriptionCreationOverride.allowAutoSubscriptionCreation ? "enabled" :
"disabled";
+ log.info("[{}] Successfully {}
autoSubscriptionCreation on namespace {}", clientAppId(), autoOverride,
namespaceName);
asyncResponse.resume(Response.noContent().build());
Review comment:
Should move to the zookeeper callback.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
