sijie commented on a change in pull request #6566: [PIP-60] [Proxy-Server]
Support SNI routing to support various proxy-server in pulsar
URL: https://github.com/apache/pulsar/pull/6566#discussion_r405737897
##########
File path:
pulsar-common/src/main/java/org/apache/pulsar/common/policies/data/ClusterData.java
##########
@@ -58,6 +60,20 @@
example = "pulsar+ssl://pulsar.example.com:6651"
)
private String brokerServiceUrlTls;
+ @ApiModelProperty(
+ name = "proxyServiceUrl",
+ value = "Proxy-service url when client would like to connect to broker
via proxy.",
+ example = "pulsar+ssl://ats-proxy.example.com:4443 or "
+ + "pulsar://ats-proxy.example.com:4080"
+ )
+ private String proxyServiceUrl;
Review comment:
based on my understanding, this service URL here can only be the binary
protocol service URL correct? We can't use the HTTP-protocol service URL. If
that's the case, can you document this setting in `ClusterData` and the related
command-line tools? It might be good to add a validation to throw exceptions if
it is not a binary protocol service url.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
