rdhabalia commented on a change in pull request #6566: [PIP-60] [Proxy-Server]
Support SNI routing to support various proxy-server in pulsar
URL: https://github.com/apache/pulsar/pull/6566#discussion_r408534778
##########
File path:
pulsar-common/src/main/java/org/apache/pulsar/common/policies/data/ClusterData.java
##########
@@ -58,6 +60,20 @@
example = "pulsar+ssl://pulsar.example.com:6651"
)
private String brokerServiceUrlTls;
+ @ApiModelProperty(
+ name = "proxyServiceUrl",
+ value = "Proxy-service url when client would like to connect to broker
via proxy.",
+ example = "pulsar+ssl://ats-proxy.example.com:4443 or "
+ + "pulsar://ats-proxy.example.com:4080"
+ )
+ private String proxyServiceUrl;
Review comment:
yes, SNI works on layer-4 so, it requires binary URL for SNI routing.
however, we added proxyUrl placeholder extensible by adding `proxyType` and
right now we support SNI and in future we can have other type which can support
HTTP as well. So, I think we don't want to restrict with binary url only. But I
have a plan to add a separate document with examples of different
proxy-solutions(ATS, Envoy) as multiple users are interested in this solution.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
