cckellogg commented on a change in pull request #6752: Support different docker
images in Kubernetes runtime of Pulsar Functions
URL: https://github.com/apache/pulsar/pull/6752#discussion_r410738498
##########
File path:
pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/kubernetes/KubernetesRuntime.java
##########
@@ -155,6 +158,9 @@
String pythonDependencyRepository,
String pythonExtraDependencyRepository,
String pulsarDockerImageName,
+ String javaFunctionDockerImageName,
+ String pythonFunctionDockerImageName,
+ String goFunctionDockerImageName,
Review comment:
This can already be achieved with no code changes by implementing your own
https://github.com/apache/pulsar/blob/master/pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/kubernetes/KubernetesManifestCustomizer.java
This class allows you to do anything to the function spec so you can set
whatever image you want.
Is there another patch coming with this? The kubernetes runtime only
supports one docker image right?. So, If I configured a python image I would
only be able to run python functions. I'm not sure this is the right approach
and think the design needs to be thought through more. Maybe a more generic
structure like a map. That way you could have images for specific runtime
version java8, java11, python3.7, python3.8, etc.. Or provide another
implementation of the KubernetesManifestCustomizer.java that supports images
for each runtime (java, python, go, etc..)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
