cckellogg commented on a change in pull request #6752:
URL: https://github.com/apache/pulsar/pull/6752#discussion_r413096921
##########
File path:
pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/kubernetes/KubernetesRuntime.java
##########
@@ -155,6 +158,9 @@
String pythonDependencyRepository,
String pythonExtraDependencyRepository,
String pulsarDockerImageName,
+ String javaFunctionDockerImageName,
+ String pythonFunctionDockerImageName,
+ String goFunctionDockerImageName,
Review comment:
I agree with the concept and idea. I was trying to brainstorm the
configuration approach of flat vs a map for the images. Would any other
information be needed for specific image? If not then flat is probably ok.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
