cckellogg commented on a change in pull request #6752:
URL: https://github.com/apache/pulsar/pull/6752#discussion_r415115606
##########
File path:
pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/kubernetes/KubernetesRuntime.java
##########
@@ -973,8 +982,19 @@ private V1PodSpec getPodSpec(List<String> instanceCommand,
Function.Resources re
V1Container getFunctionContainer(List<String> instanceCommand,
Function.Resources resource) {
final V1Container container = new
V1Container().name(PULSARFUNCTIONS_CONTAINER_NAME);
- // set up the container images
- container.setImage(pulsarDockerImageName);
+ // By default, if we do not use the function image of a specific
language, then we will support all languages.
+ if (javaFunctionDockerImageName == null &&
pythonFunctionDockerImageName == null && goFunctionDockerImageName == null) {
Review comment:
You need to check the runtime of the function and then set the image
based on that.
`instanceConfig.getFunctionDetails().getRuntime()`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
