jerrypeng commented on a change in pull request #7647:
URL: https://github.com/apache/pulsar/pull/7647#discussion_r459715084
##########
File path:
pulsar-functions/utils/src/main/java/org/apache/pulsar/functions/utils/FunctionConfigUtils.java
##########
@@ -639,6 +655,16 @@ private static void doCommonChecks(FunctionConfig
functionConfig) {
if ((functionConfig.getMaxMessageRetries() == null ||
functionConfig.getMaxMessageRetries() < 0) &&
!org.apache.commons.lang3.StringUtils.isEmpty(functionConfig.getDeadLetterTopic()))
{
throw new IllegalArgumentException("Dead Letter Topic specified,
however max retries is set to infinity");
}
+ if (functionConfig.getRetainKeyOrdering() != null
+ && functionConfig.getRetainKeyOrdering()
Review comment:
I would remove this stanza. We should return an error if the retain
order or retain key ordering is set at all
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
