jerrypeng commented on a change in pull request #7647:
URL: https://github.com/apache/pulsar/pull/7647#discussion_r459718664
##########
File path:
pulsar-functions/utils/src/main/java/org/apache/pulsar/functions/utils/FunctionConfigUtils.java
##########
@@ -317,9 +319,15 @@ public static FunctionConfig
convertFromDetails(FunctionDetails functionDetails)
}
if (functionDetails.getSource().getSubscriptionType() ==
Function.SubscriptionType.FAILOVER) {
Review comment:
This whole conditional statement doesn't see right to me. Why are se
setting the processing guarantee by looking at what the subscription is? We
already setting the processing guarantee in a previous line:
https://github.com/apache/pulsar/pull/7647/files#diff-239e167c18ea8591c85432948ab5040aL297
##########
File path:
pulsar-functions/utils/src/main/java/org/apache/pulsar/functions/utils/FunctionConfigUtils.java
##########
@@ -317,9 +319,15 @@ public static FunctionConfig
convertFromDetails(FunctionDetails functionDetails)
}
if (functionDetails.getSource().getSubscriptionType() ==
Function.SubscriptionType.FAILOVER) {
Review comment:
This whole conditional statement doesn't seem right to me. Why are se
setting the processing guarantee by looking at what the subscription is? We
already setting the processing guarantee in a previous line:
https://github.com/apache/pulsar/pull/7647/files#diff-239e167c18ea8591c85432948ab5040aL297
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
