[GitHub] [pulsar-client-go] shohi commented on a change in pull request #323: define logger interface and add Logger field to ClientOptions

[GitBox]

shohi commented on a change in pull request #323:
URL: https://github.com/apache/pulsar-client-go/pull/323#discussion_r471217577



##########
File path: pulsar/producer_impl.go
##########
@@ -61,7 +60,7 @@ type producer struct {
        ticker        *time.Ticker
        tickerStop    chan struct{}
 
-       log *log.Entry

Review comment:
       as mentioned above, i think using `logger` as field name is more 
idiomatic.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org