racorn edited a comment on issue #8056: URL: https://github.com/apache/pulsar/issues/8056#issuecomment-692369682
@rdhabalia Thank you very much! I think the refactoring improved the code in several ways and is easier to read as well. As a side note: Would there be any concurrency issues to worry about the way the `ConnectionPool` uses its `channelInitializerHandler`, specifically the invocation of `channelInitializerHandler.setSniHostName/setSniHostPort` before making a client connection? I do not know Pulsar very well, but if the `ConnectionPool` is used by multiple threads, and one thread tries to connect to broker-a at the same time another thread tries to connect to broker-b, could there be a race condition so a connection attempt to broker-a would use the SNI values that apply to broker-b? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
