jerrypeng commented on a change in pull request #8098:
URL: https://github.com/apache/pulsar/pull/8098#discussion_r492895582
##########
File path:
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java
##########
@@ -627,6 +627,8 @@ protected void validateFunctionConfigs(FunctionConfig
functionConfig) {
protected Integer instanceIdOffset = 0;
@Parameter(names = "--runtime", description = "either THREAD or
PROCESS. Only applies for Java functions")
protected String runtime;
+ @Parameter(names = "--environment-based-secrets-provider", description
= "Should we use environment based secret provider")
Review comment:
Actually we should just let the user to specify class of the secrets
configurator to use. That is simplest and generic.
--secrets-provider-configurator-classname
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
