jerrypeng commented on a change in pull request #8098:
URL: https://github.com/apache/pulsar/pull/8098#discussion_r492928425
##########
File path:
pulsar-functions/localrun/src/main/java/org/apache/pulsar/functions/LocalRunner.java
##########
@@ -418,11 +428,24 @@ private void
startThreadedMode(org.apache.pulsar.functions.proto.Function.Functi
int parallelism, int
instanceIdOffset, String serviceUrl,
String stateStorageServiceUrl,
AuthenticationConfig authConfig,
String userCodeFile) throws
Exception {
+ SecretsProvider secretsProvider;
+ if (secretsProviderClassName != null) {
+ if
(secretsProviderClassName.equals(ClearTextSecretsProvider.class.getName())) {
Review comment:
Just create an instance using the class name. Use method:
https://github.com/apache/pulsar/blob/master/pulsar-common/src/main/java/org/apache/pulsar/common/util/Reflections.java#L64
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
