aloyszhang commented on a change in pull request #9039:
URL: https://github.com/apache/pulsar/pull/9039#discussion_r548337507
##########
File path:
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/ManagedLedger.java
##########
@@ -520,4 +587,14 @@ void asyncSetProperties(Map<String, String> properties,
final AsyncCallbacks.Upd
* Roll current ledger if it is full
*/
void rollCurrentLedgerIfFull();
+
+ /**
+ * Find position by sequenceId.
+ * */
+ CompletableFuture<PositionImpl>
asyncFindPosition(com.google.common.base.Predicate<Entry> predicate);
Review comment:
`condition` of `OpFindNewest` is `com.google.common.base.Predicate`
type, so the parameter type here should alos be
`com.google.common.base.Predicate`
##########
File path:
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
##########
@@ -550,6 +566,11 @@ public Position addEntry(byte[] data) throws
InterruptedException, ManagedLedger
return addEntry(data, 0, data.length);
}
+ @Override
+ public Position addEntry(byte[] data, int batchSize) throws
InterruptedException, ManagedLedgerException {
+ return addEntry(data, batchSize,0, data.length);
Review comment:
fixed
##########
File path:
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
##########
@@ -672,8 +747,27 @@ private synchronized void internalAsyncAddEntry(OpAddEntry
addOperation) {
addOperation.setCloseWhenDone(true);
STATE_UPDATER.set(this, State.ClosingLedger);
}
+ // interceptor entry before add to bookie
+ if (beforeAddEntry(addOperation)) {
+ addOperation.initiate();
+ }
+ }
+ }
- addOperation.initiate();
+ private boolean beforeAddEntry(OpAddEntry addOperation) {
+ // if no interceptor, just return true to make sure addOperation will
be initiate()
+ if (managedLedgerInterceptor == null) {
+ return true;
+ }
+ try {
+ managedLedgerInterceptor.beforeAddEntry(addOperation,
addOperation.getBatchSize());
+ return true;
+ } catch (Exception e) {
+ addOperation.failed(
+ new ManagedLedgerInterceptException("Interceptor managed
ledger before add to bookie failed."));
+ ReferenceCountUtil.release(addOperation.data);
+ log.error("[{}] Failed to interceptor entry before add to
bookie.", name, e);
Review comment:
fixed
##########
File path:
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/interceptor/ManagedLedgerInterceptor.java
##########
@@ -0,0 +1,34 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.bookkeeper.mledger.interceptor;
+
+import org.apache.bookkeeper.client.LedgerHandle;
+import org.apache.bookkeeper.mledger.impl.OpAddEntry;
+
+import java.util.Map;
+
+/**
+ * Interceptor for ManagedLedger.
+ * */
+public interface ManagedLedgerInterceptor {
Review comment:
fixed
##########
File path:
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/interceptor/ManagedLedgerInterceptor.java
##########
@@ -0,0 +1,34 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.bookkeeper.mledger.interceptor;
+
+import org.apache.bookkeeper.client.LedgerHandle;
+import org.apache.bookkeeper.mledger.impl.OpAddEntry;
+
+import java.util.Map;
+
+/**
+ * Interceptor for ManagedLedger.
+ * */
+public interface ManagedLedgerInterceptor {
+ OpAddEntry beforeAddEntry(OpAddEntry op, int batchSize);
Review comment:
fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
