sijie commented on a change in pull request #9039:
URL: https://github.com/apache/pulsar/pull/9039#discussion_r548422134



##########
File path: 
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/ManagedLedger.java
##########
@@ -520,4 +587,14 @@ void asyncSetProperties(Map<String, String> properties, 
final AsyncCallbacks.Upd
      * Roll current ledger if it is full
      */
     void rollCurrentLedgerIfFull();
+
+    /**
+     * Find position by sequenceId.
+     * */
+    CompletableFuture<PositionImpl> 
asyncFindPosition(com.google.common.base.Predicate<Entry> predicate);

Review comment:
       I'd recommend using java.util.Predicate in the interface. You can just 
write a wrapper to convert a java.util.Predicate to a guava Predicate.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to