315157973 commented on a change in pull request #9290:
URL: https://github.com/apache/pulsar/pull/9290#discussion_r563226704
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java
##########
@@ -2751,19 +2751,19 @@ protected void
internalSetMaxSubscriptionsPerTopic(Integer maxSubscriptionsPerTo
internalSetPolicies("max_subscriptions_per_topic",
maxSubscriptionsPerTopic);
}
- protected void internalSetMaxUnackedMessagesPerSubscription(int
maxUnackedMessagesPerSubscription) {
+ protected void internalSetMaxUnackedMessagesPerSubscription(Integer
maxUnackedMessagesPerSubscription) {
validateNamespacePolicyOperation(namespaceName,
PolicyName.MAX_UNACKED, PolicyOperation.WRITE);
validatePoliciesReadOnlyAccess();
-
+ if (maxUnackedMessagesPerSubscription != null &&
maxUnackedMessagesPerSubscription < 0) {
Review comment:
Just set it to 0, which is consistent with the description in
broker.conf, but here it just cannot be set less than 0
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
