sijie commented on a change in pull request #9290:
URL: https://github.com/apache/pulsar/pull/9290#discussion_r563434214



##########
File path: 
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java
##########
@@ -2731,7 +2731,7 @@ protected void 
internalSetMaxUnackedMessagesPerConsumer(int maxUnackedMessagesPe
         }
     }
 
-    protected int internalGetMaxUnackedMessagesPerSubscription() {
+    protected Integer internalGetMaxUnackedMessagesPerSubscription() {

Review comment:
       It is better to have a PIP for this change. We should highlight it in 
the release notes.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to