lhotari commented on a change in pull request #9420:
URL: https://github.com/apache/pulsar/pull/9420#discussion_r568375890
##########
File path:
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/ConsumedLedgersTrimTest.java
##########
@@ -142,6 +143,14 @@ public void testConsumedLedgersTrimNoSubscriptions()
throws Exception {
// the lastMessageId is still on the previous ledger
restartBroker();
// force load topic
+ Awaitility.await().atMost(5, TimeUnit.SECONDS).until(() -> {
+ try {
+ pulsar.getBrokerService().getTopicIfExists(topicName).get(3,
TimeUnit.SECONDS).get();
+ return true;
+ } catch (Exception ignored) {
+ }
Review comment:
Yes you are right @315157973 , untilAsserted will only catch
AssertionErrors . I'm sorry about the incorrect advice.
Your original approach seemed to be the best approach after all since it
would also handle the case of an exception being caught.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
