lhotari commented on a change in pull request #9420:
URL: https://github.com/apache/pulsar/pull/9420#discussion_r568378053
##########
File path:
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/ConsumedLedgersTrimTest.java
##########
@@ -142,6 +143,14 @@ public void testConsumedLedgersTrimNoSubscriptions()
throws Exception {
// the lastMessageId is still on the previous ledger
restartBroker();
// force load topic
+ Awaitility.await().atMost(5, TimeUnit.SECONDS).until(() -> {
+ try {
+ pulsar.getBrokerService().getTopicIfExists(topicName).get(3,
TimeUnit.SECONDS).get();
+ return true;
+ } catch (Exception ignored) {
+ }
Review comment:
`catchUncaughtExceptions` defaults to true in Awaitility, so after all,
untilAsserted should be fine without catching the exception. @315157973 Have
you actually checked that RuntimeException terminates untilAsserted?
##########
File path:
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/ConsumedLedgersTrimTest.java
##########
@@ -142,6 +145,12 @@ public void testConsumedLedgersTrimNoSubscriptions()
throws Exception {
// the lastMessageId is still on the previous ledger
restartBroker();
// force load topic
+ Awaitility.await().untilAsserted(() -> {
+ try {
+
assertNotNull(pulsar.getBrokerService().getTopicIfExists(topicName).get(3,
TimeUnit.SECONDS).get());
+ } catch (Exception ignored) {
Review comment:
I think this should be removed since Awaitility catches
RuntimeExceptions by default.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
