rueian opened a new pull request #467:
URL: https://github.com/apache/pulsar-client-go/pull/467
Fixes #356
Fixes #419
### Motivtions
The changes made by the original PR #329 are no longer works.
This PR is trying to fix the bugs and make the test case be more robust.
### Moditications
* fix the wrong `pc.startMessageID == lastestMessageID` with
`pc.startMessageID.equal(lastestMessageID.(messageID))`
* fix the hanging `pc.requestSeek(msgID.messageID)` with
`pc.requestSeekWithoutClear(msgID.messageID)` before the dispatch loop
* make `HasNext()` return true in case of `StartMessageIdInclusive` and
`LastestMessageID`
* make `TestReaderLatestInclusiveHasNext` test case be more robust
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
This change is already covered by existing tests, such as
`TestReaderLatestInclusiveHasNext`.
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (no)
- The public API: (no)
- The schema: (no)
- The default values of configurations: (no)
- The wire protocol: (no)
### Documentation
- Does this pull request introduce a new feature? (no)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
