golden-yang commented on a change in pull request #9738:
URL: https://github.com/apache/pulsar/pull/9738#discussion_r584462661
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java
##########
@@ -957,8 +957,9 @@ public NamespaceService getNamespaceService() {
return functionWorkerService;
}
- public WorkerService getWorkerService() {
- return functionWorkerService.orElse(null);
+ public WorkerService getWorkerService() throws
UnsupportedOperationException {
+ return functionWorkerService.orElseThrow(() -> new
UnsupportedOperationException("Pulsar Function Worker is not " +
+ "enabled, probably functionsWorkerEnabled is set to false"));
Review comment:
Using getWorkerServiceOpt directly may be a more elegant implementation,
but it will change too many places, and the expected behavior of most methods
is also to throw a clearer exception.
In your opinion, which one is better?
Simplify the implementation or use a more elegant return value.
Maybe you have a better idea, Thank you again for your advice
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
