eolivelli commented on a change in pull request #9716:
URL: https://github.com/apache/pulsar/pull/9716#discussion_r584601470
##########
File path:
pulsar-testclient/src/main/java/org/apache/pulsar/testclient/PerformanceProducer.java
##########
@@ -109,7 +108,7 @@
@Parameter(names = { "-s", "--size" }, description = "Message size
(bytes)")
public int msgSize = 1024;
- @Parameter(names = { "-t", "--num-topic" }, description = "Number of
topics")
+ @Parameter(names = { "-t", "--num-topics" }, description = "Number of
topics")
Review comment:
are we breaking compatibility with the previous version ?
##########
File path:
pulsar-testclient/src/main/java/org/apache/pulsar/testclient/PerformanceConsumer.java
##########
@@ -72,8 +71,8 @@
@Parameter(names = { "--conf-file" }, description = "Configuration
file")
public String confFile;
- @Parameter(description = "persistent://prop/ns/my-topic", required =
true)
- public List<String> topic;
+ @Parameter(description = "A list of topics to consume from (e.g.
persistent://prop/ns/topic1 persistent://prop/ns/topic2)", required = true)
+ public List<String> topics;
Review comment:
are we breaking compatibility with the old format ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
