eolivelli commented on pull request #9716:
URL: https://github.com/apache/pulsar/pull/9716#issuecomment-791462981
@codelipenghui I agree.
But I added a comment and asked explicitly to not change the behaviour.
IMHO This is not about tests, it is about taking care of comments of the
users in the community.
In my experience in OSS projects, and especially in the ASF,
if anyone "request changes" or anyway has a perplexity regarding a change,
it is necessary to understand the problem deeper before moving forward with
committing the patch.
Think about any other user/contributor that tries to comment and express his
opinion on a change, but the owners of the project ignore his comments and go
forward.......
how can the newcomer feel ?
This is not a good behaviour indeed.
Please take this into consideration for the next time.
The is no hurry in committing a patch in Apache projects,
but we must ensure that everybody feels well in the community
:-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
