lhotari commented on a change in pull request #9448:
URL: https://github.com/apache/pulsar/pull/9448#discussion_r585520586
##########
File path: pulsar-io/kafka/pom.xml
##########
@@ -54,6 +54,31 @@
<version>${kafka-client.version}</version>
</dependency>
+ <dependency>
+ <groupId>io.confluent</groupId>
+ <artifactId>kafka-schema-registry</artifactId>
+ <version>${kafka.confluent.schemaregistryclient.version}</version>
+ </dependency>
+
+ <dependency>
+ <groupId>io.confluent</groupId>
+ <artifactId>kafka-avro-serializer</artifactId>
+ <version>${kafka.confluent.avroserializer.version}</version>
+ </dependency>
+
+ <dependency>
+ <groupId>io.confluent</groupId>
+ <artifactId>kafka-streams-avro-serde</artifactId>
+ <version>${kafka.confluent.avroserializer.version}</version>
+ </dependency>
+
+ <dependency>
+ <groupId>org.apache.pulsar</groupId>
+ <artifactId>pulsar-client-original</artifactId>
+ <version>${project.version}</version>
+ <scope>compile</scope>
+ </dependency>
Review comment:
Is the pulsar-client-original dependency needed in the compile scope?
the problem is that it will pull a lot of dependencies to the .nar files that
are built. Perhaps `provided` scope would be fine? However I think that
`provided` scope isn't transient and therefore it might not have the desired
impact in this library.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
