eolivelli commented on pull request #9716: URL: https://github.com/apache/pulsar/pull/9716#issuecomment-792597210
@murong00 don't worry at all! let's fix this together. I appreciate that you are volunteering to follow up. Thank you very much. I really would like to see that same behaviour as before, otherwise the behaviour of the tool is different from one version to another and you cannot know which version of the tool you are using. I am maintaining a suite of tests that are to be run against several different versions of Pulsar. It is fine to ADD new features, but NOT to change the behaviour. So out-of-the-box it would be great that the behaviour does not change. So adding a new "compatibility mode" flag won't work for me, because I cannot pass that flag to old versions. I was going to start writing a patch in order to fallback to 2.7 mode in case you pass only one topic to the command. `pulsar-perf produce -n 10 test` here we see that the user is selecting only one topic and asking for 10...so we can expand the list of topics to test-1, test-2, test-3.... this way we are 100% compatible with previous behaviour and your new behaviour works as well The same is for `pulsar-perf consume` please I will be happy to test your patch ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
