dlg99 commented on a change in pull request #9825:
URL: https://github.com/apache/pulsar/pull/9825#discussion_r589668675
##########
File path: distribution/io/src/assemble/io.xml
##########
@@ -47,7 +47,7 @@
<file><source>${basedir}/../../pulsar-io/cassandra/target/pulsar-io-cassandra-${project.version}.nar</source></file>
<file><source>${basedir}/../../pulsar-io/twitter/target/pulsar-io-twitter-${project.version}.nar</source></file>
-
<file><source>${basedir}/../../pulsar-io/kafka/target/pulsar-io-kafka-${project.version}.nar</source></file>
Review comment:
@sijie I might be missing some context, what it can break? The nar file
name/source path is changed.
Similar change is https://github.com/apache/pulsar/pull/9808 - am I missing
some context that will help me understand why that one was safe and this one is
not?
I relied on integration tests to catch potential breaks, please let me know
if there is something the tests won't catch, how can I confirm that everything
works fine in this case?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
