sijie commented on a change in pull request #9825:
URL: https://github.com/apache/pulsar/pull/9825#discussion_r589760952
##########
File path: distribution/io/src/assemble/io.xml
##########
@@ -47,7 +47,7 @@
<file><source>${basedir}/../../pulsar-io/cassandra/target/pulsar-io-cassandra-${project.version}.nar</source></file>
<file><source>${basedir}/../../pulsar-io/twitter/target/pulsar-io-twitter-${project.version}.nar</source></file>
-
<file><source>${basedir}/../../pulsar-io/kafka/target/pulsar-io-kafka-${project.version}.nar</source></file>
Review comment:
I missed #9808. There is no breaking change here.
#9808 is fine because the adopter is used for both standalone connector and
a dependency for debezium connector. This goes to my major comment. I don't
think you should put the Kafka sink connector wrapper in Kafka connector. It
should go to the `pulsar-io-kafka-connect-adaptor` module.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
