codelipenghui commented on a change in pull request #9852:
URL: https://github.com/apache/pulsar/pull/9852#discussion_r590870619
##########
File path:
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
##########
@@ -2954,6 +2955,7 @@ private void cleanupOffloaded(long ledgerId, UUID uuid,
String offloadDriverName
* identify offloader
*/
Map<String, String> offloadDriverMetadata, String cleanupReason) {
+ log.info("cleanup offloaded data uuid {} for reason {}",
uuid.toString(), cleanupReason);
Review comment:
It's better to also print the managed ledger name so that we can
distinguish which topic occurs the problem. And also print the ledgerId? it's
useful for debugging.
Use info level log looks good here since the cleanupOffloaded only happens
while offload failed right @gaoran10
##########
File path:
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
##########
@@ -2764,6 +2764,7 @@ private void offloadLoop(CompletableFuture<PositionImpl>
promise, Queue<LedgerIn
scheduledExecutor, name)
.whenComplete((ignore2, exception) -> {
if (exception != null) {
+ log.error("Failed to offload data for
ledgerId {}", ledgerId, exception);
Review comment:
It's better to also print the managed ledger name so that we can
distinguish which topic occurs the problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
