michaeljmarshall commented on a change in pull request #9852:
URL: https://github.com/apache/pulsar/pull/9852#discussion_r591651520



##########
File path: 
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
##########
@@ -2764,6 +2764,7 @@ private void offloadLoop(CompletableFuture<PositionImpl> 
promise, Queue<LedgerIn
                                            scheduledExecutor, name)
                             .whenComplete((ignore2, exception) -> {
                                     if (exception != null) {
+                                        log.error("Failed to offload data for 
ledgerId {}", ledgerId, exception);

Review comment:
       For consistency, it might be helpful to also add the ledger's name to 
the warning log that occurs when the cleanup offload fails (line 2962).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to