merlimat commented on a change in pull request #9850:
URL: https://github.com/apache/pulsar/pull/9850#discussion_r592539518
##########
File path:
pulsar-common/src/main/java/org/apache/pulsar/common/policies/data/Policies.java
##########
@@ -43,13 +45,19 @@
public Set<String> replication_clusters = Sets.newHashSet();
public BundlesData bundles;
@SuppressWarnings("checkstyle:MemberName")
- public Map<BacklogQuota.BacklogQuotaType, BacklogQuota> backlog_quota_map
= Maps.newHashMap();
+ @JsonDeserialize(as = ConcurrentHashMap.class)
Review comment:
I'd rather not follow this approach because it leaves out other fields
(that are also non-thread-safe) and other classes that will have the same issue.
Instead, we should try to find a way to the handling of modifications to
these policies is synchronized.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
