lhotari commented on a change in pull request #9850:
URL: https://github.com/apache/pulsar/pull/9850#discussion_r592667635
##########
File path:
pulsar-common/src/main/java/org/apache/pulsar/common/policies/data/Policies.java
##########
@@ -43,13 +45,19 @@
public Set<String> replication_clusters = Sets.newHashSet();
public BundlesData bundles;
@SuppressWarnings("checkstyle:MemberName")
- public Map<BacklogQuota.BacklogQuotaType, BacklogQuota> backlog_quota_map
= Maps.newHashMap();
+ @JsonDeserialize(as = ConcurrentHashMap.class)
Review comment:
@merlimat That's true that there is this uncomfortable feeling. :)
However, it seems that this ConcurrentHashMap based solution makes a lot of
sense in this context. One of the benefits is that the change doesn't require
huge architectural changes and the risk that it impacts performance is very
minor.
> Instead, we should try to find a way to the handling of modifications to
these policies is synchronized.
Does that help? Wouldn't it mean that reads are also synchronized? Wouldn't
that impact performance? Perhaps I misunderstood what you meant with
"synchronized".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
