eolivelli commented on a change in pull request #9900:
URL: https://github.com/apache/pulsar/pull/9900#discussion_r594960354
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java
##########
@@ -799,27 +799,22 @@ protected void internalSetAutoTopicCreation(AsyncResponse
asyncResponse,
"Number of partitions should be less than or equal to
" + maxPartitions);
}
}
- // Force to read the data s.t. the watch to the cache content is setup.
- namespaceResources().setAsync(path(POLICIES,
namespaceName.toString()), (policies) -> {
- policies.autoTopicCreationOverride = autoTopicCreationOverride;
- return policies;
- }).thenApply(r -> {
+ try {
Review comment:
now that we fixed setAsync there is no need to change this block.
also it is better to keep the async style
the same applies to the other `updatePolicies`. calls
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
