merlimat commented on a change in pull request #9900:
URL: https://github.com/apache/pulsar/pull/9900#discussion_r595710666
##########
File path:
pulsar-metadata/src/main/java/org/apache/pulsar/metadata/cache/impl/MetadataCacheImpl.java
##########
@@ -166,6 +165,8 @@ private MetadataCacheImpl(MetadataStore store,
MetadataSerde<T> serde) {
T newValueObj;
byte[] newValue;
try {
+ // Use clone and CAS zk to ensure thread safety
Review comment:
We should do the same operation on the `readModifyUpdateOrCreate` method
as well
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
