lhotari commented on a change in pull request #9308:
URL: https://github.com/apache/pulsar/pull/9308#discussion_r602057809
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java
##########
@@ -429,6 +454,10 @@ public void close() throws PulsarServerException {
state = State.Closed;
isClosedCondition.signalAll();
+ CompletableFuture<Void> shutdownFuture =
+ CompletableFuture.allOf(asyncCloseFutures.toArray(new
CompletableFuture[0]));
+ closeFutureReference.set(shutdownFuture);
+ return shutdownFuture;
} catch (Exception e) {
if (e instanceof CompletionException && e.getCause() instanceof
MetadataStoreException) {
throw new
PulsarServerException(MetadataStoreException.unwrap((CompletionException) e));
Review comment:
I've made changes in that direction. please check the most recent
changes whether I understood correctly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
